Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release is broken (view contents go out of sync?) #120

Closed
FichteFoll opened this issue Aug 30, 2022 · 6 comments
Closed

Latest release is broken (view contents go out of sync?) #120

FichteFoll opened this issue Aug 30, 2022 · 6 comments

Comments

@FichteFoll
Copy link

FichteFoll commented Aug 30, 2022

After updating to 1.1.0, I've encountered several serious problems. Following is a probably incomplete list:

  • Highlighted regions go out of sync all the time when editing the file.
    2022-08-30_14-18-30
    (expected: blue line under the assigned-brands class and orange under anchor-tooltip)

  • Some error marks are simply wrong and incorrect, e.g. a tag supposedly not being closed. My theory is that they were valid at some point in the edit history and have long since been fixed, but LSP still marks them until I close and re-open the view. And they keep accumulating.

  • "0 references" code lens shown on CSS properties (?)
    2022-08-30_13-45-52

@FichteFoll FichteFoll changed the title Latest release is broken (regions go out of sync) Latest release is broken (view contents go out of sync?) Aug 30, 2022
@rchl
Copy link
Member

rchl commented Aug 30, 2022

I feel that those kind of issues could be reported directly in the volar repo sine we can't do much about those here (besides reverting to an older version).

But for now gonna ping @johnsoncodehk

@FichteFoll
Copy link
Author

I wasn't sure if it's a general volar issue or one with the plugin for ST, so I went with the lowest known source of failure. It can then bubble up as necessary. I also imagined that there would be a fairly big report of this on the volar repo already, but perhaps nobody has updated to the latest version yet.

@johnsoncodehk
Copy link
Contributor

It should be fixed by vuejs/language-tools@e2090ee.

@johnsoncodehk
Copy link
Contributor

Please try @volar/vue-language-server v0.40.5.

@ElMassimo
Copy link
Collaborator

ElMassimo commented Aug 31, 2022

Thanks Johnson, can confirm that v0.40.5 fixes the issue 😃

Tested by overriding LSP-volar by adding Packages/LSP-volar/server/package-lock.json locked to v0.40.5 (instead of v0.40.4 as the latest release of LSP-volar).

@rchl
Copy link
Member

rchl commented Aug 31, 2022

@rchl rchl closed this as completed Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants