Wrong SessionView destroyed on restarting session

[rchl]

Describe the bug

I've noticed that triggering "Restart server" on a file with active LSP-rust-analyzer session typically results in didClose being sent to the newly created session which is probably also the reason that inlay hints don't always show up properly after such action.

It looks like the culprit is the code that triggers after old session was destroyed but after new session has already started. This then destroys SessionView based on config name which obviously is not a good key for differentiating two instances of the Session for the same server.

LSP/plugin/documents.py

Lines 222 to 228 in 346599a

	def on_session_shutdown_async(self, session: Session) -> None:
	removed_session = self._session_views.pop(session.config.name, None)
	if removed_session:
	removed_session.on_before_remove()
	if not self._session_views:
	self.view.settings().erase("lsp_active")
	self._registered = False

To Reproduce

1. Install LSP-rust-analyzer
2. Open some *.rs file
3. LSP: Restart session
4. Watch the logs

Environment (please complete the following information):

• Sublime Text version: 4150
• LSP version: latest commit as of now

[rchl]

Also this can result in auto complete triggers being removed from view settings due to those being out of order:

SessionView._clear_auto_complete_triggers
SessionView._clear_auto_complete_triggers
SessionView._setup_auto_complete_triggers
SessionView._clear_auto_complete_triggers

[jwortmann]

I think this is also the cause for infinite initialize -> exit loops when you move a tab between windows and if it was the last tab of the session (doesn't happen all the time, but more often than not).

[rchl]

Two ways of addressing this come to mind:

1. ensure that only one instance of given config is running at the time (fully shut down one before starting another one)
2. have unique/random IDs for each session

In the second case, we'd still have to use config name for at least auto complete triggers settings since on restarting ST we need to be able to lookup existing settings.