Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for upgrade of bracex and wcmatch libraries #2455

Closed
deathaxe opened this issue Apr 20, 2024 · 6 comments
Closed

Prepare for upgrade of bracex and wcmatch libraries #2455

deathaxe opened this issue Apr 20, 2024 · 6 comments

Comments

@deathaxe
Copy link
Contributor

If the dust has settled with transitioning to python 3.8, two PRs are prepared to upgrade

by shipping them directly from pypi for python 3.8

I already installed them manually and haven't seen any negative impacts so far. Maybe someone more involved could double check for possible incompatibilities, especially as version numbers of wcmatch differ significantly.

@predragnikolic
Copy link
Member

bracex is used by wcmatch
wcmatch still exposes the same API that LSP uses.
The behavior might be different however.

Do you maybe have a guide on how to install those deps locally?

@deathaxe
Copy link
Contributor Author

You can download the whl files and directly extract them into ST's Lib/python38 folder.

Make sure to remove the currently installed libraries' folders first.

@predragnikolic
Copy link
Member

I will start with testing this.

@predragnikolic
Copy link
Member

If someone want to also try to test it out.
You would need to keep the bracex-2.1.1.dist-info and wcmatch-1.2.1.dist-info
and change the INSTALLER to not point to Package Control

@predragnikolic
Copy link
Member

I have't run into any issues in the past two weeks.

@predragnikolic
Copy link
Member

I will close this issue, because there are no code changes that needs to be done on the LSP side,
and I haven't noticed any regressions.

Feel free to reopen this is you think otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants