Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problems variable name shadows / conflicts with struct name #142

Open
javorszky opened this issue Feb 23, 2022 · 3 comments
Open

problems variable name shadows / conflicts with struct name #142

javorszky opened this issue Feb 23, 2022 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@javorszky
Copy link
Contributor

It's in the directive validator: https://github.com/suborbital/atmo/blob/main/directive/directive_validator.go#L16

@javorszky javorszky added bug Something isn't working good first issue Good for newcomers labels Feb 23, 2022
@AYM1607
Copy link

AYM1607 commented May 17, 2022

Could you provide more details? I'd like to take a crack at this. I'm assuming it's the problems variable which is called the same as the user defined types.

@javorszky
Copy link
Contributor Author

Hi! Thanks for the offer 🙂

Yes, you're right, the variable and the type should not be named the same.

@bishal7679
Copy link
Contributor

@javorszky Can you review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants