Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI failure on TestEngineFetch #414

Open
callahad opened this issue Apr 5, 2023 · 1 comment
Open

CI failure on TestEngineFetch #414

callahad opened this issue Apr 5, 2023 · 1 comment

Comments

@callahad
Copy link

callahad commented Apr 5, 2023

Our CI workflow has started failing at:

--- FAIL: TestEngineFetch (0.27s)
panic: interface conversion: interface {} is *request.CoordinatedResponse, not []uint8 [recovered]
	panic: interface conversion: interface {} is *request.CoordinatedResponse, not []uint8

goroutine 31 [running]:
testing.tRunner.func1.2({0x13c9ce0, 0xc0012d0060})
	/opt/hostedtoolcache/go/1.20.2/x64/src/testing/testing.go:1526 +0x24e
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.20.2/x64/src/testing/testing.go:1529 +0x39f
panic({0x13c9ce0, 0xc0012d0060})
	/opt/hostedtoolcache/go/1.20.2/x64/src/runtime/panic.go:884 +0x213
github.com/suborbital/e2core/sat/engine2/enginetest.TestEngineFetch(0xc000170680)
	/home/runner/work/e2core/e2core/sat/engine2/enginetest/engine_test.go:159 +0x758
testing.tRunner(0xc000170680, 0x1450e80)
	/opt/hostedtoolcache/go/1.20.2/x64/src/testing/testing.go:[157](https://github.com/suborbital/e2core/actions/runs/4619606359/jobs/8168575352?pr=413#step:7:158)6 +0x10b
created by testing.(*T).Run
	/opt/hostedtoolcache/go/1.20.2/x64/src/testing/testing.go:[162](https://github.com/suborbital/e2core/actions/runs/4619606359/jobs/8168575352?pr=413#step:7:163)9 +0x3ea
FAIL	github.com/suborbital/e2core/sat/engine2/enginetest	0.484s

Looking at the Actions dashboard, this is a recent failure:

Screenshot 2023-04-05 at 16 00 05

This workflow successfully ran as part of PR #411 on April 1st, and we've not merged anything since then, so something external has changed to cause this failure.

@javorszky
Copy link
Contributor

So that one is... basically it fetches the 1password error page, and fails and returns whatever was fetched.

The moment 1password changes the html of their error page, this will start failing.

See https://github.com/suborbital/e2core/blob/main/sat/engine2/enginetest/engine_test.go#L158-L160

javorszky added a commit that referenced this issue Apr 5, 2023
* fix: Use fresh instance on each new plugin invocation

* Skip test that depends on 1password page html, see #414

* Pass in instance we want to close to deferred function

---------

Co-authored-by: Gabor Javorszky <gabor@suborbital.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants