Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browserify.prototype._json adds a module.exports without testing if it's dedupe code or not #1101

Closed
tetsuo opened this issue Feb 1, 2015 · 3 comments
Closed

Browserify.prototype._json adds a module.exports without testing if it's dedupe code or not #1101

tetsuo opened this issue Feb 1, 2015 · 3 comments

Comments

@tetsuo
Copy link

tetsuo commented Feb 1, 2015

encountered this while trying to rebuild crypto-browserify with watchify. one of its dependencies (elliptic) requires a package.json somewhere.

hotfix here: https://github.com/tetsuo/node-browserify/commit/9978df3a1c6fe0abbcdac9b1f2729fbbb3687b04
@epd
Copy link

epd commented Feb 4, 2015

I can confirm this as well, using Browserify @ 8.1.3 and Watchify @ 2.3.0. @tetsuo's hotfix worked for me as well.

epd added a commit to epd/node-browserify that referenced this issue Feb 6, 2015
@epd
Hotfix via browserify#1101
74b8305
@mgmorcos
Copy link

mgmorcos commented Feb 9, 2015

👍

@steffenmllr steffenmllr mentioned this issue Feb 13, 2015
Closed
@magus magus mentioned this issue Feb 16, 2015
Closed
@ghost ghost mentioned this issue Feb 21, 2015
Closed
@ghost
Copy link

ghost commented Feb 21, 2015

Published the hotfix in 9.0.3. Thanks for the fix!

@ghost ghost closed this as completed Feb 21, 2015
@renovate renovate bot mentioned this issue Jun 6, 2021
Open
1 task
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tetsuo @epd @mgmorcos