Optimization: Add syntax check cache #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattdesl Thanks for pointing this out! |
|
LGTM. |
zertosh
added a commit
that referenced
this pull request
May 14, 2015
Optimization: Add syntax check cache
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a caching system for the syntax check. It's a big optimization for repeat builds (think watchify). I had proposed this first in browserify/syntax-error#9, but substack suggested that it was better implemented here.
I went with a per instance cache instead of a global cache (though it could very safely be one) because I don't want to set the precedent that it's ok for Browserify to be stateful.