Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix globals transform noParse path matcher #1257

Merged
merged 2 commits into from May 14, 2015
Merged

Fix globals transform noParse path matcher #1257

merged 2 commits into from May 14, 2015

Conversation

zertosh
Copy link
Member

@zertosh zertosh commented May 9, 2015

  • Fix globals transform noParse path matcher
    • Fixes passing in a function. The logic to call the function is there, but if you passed one in, path.resolve would throw because it wasn't a string.
    • Fixes resolving from the basedir - not assuming it's the cwd.
    • Optimizes a bit by moving no and absno into the closure so they're only built once per b.bundle().
    • Adds some tests for this.
  • Add test for "noParse"
    • Adds a test for the only way noParse for deps works - an array of full paths.

(related to #1256)

@zertosh
Copy link
Member Author

zertosh commented May 12, 2015

@jmm @terinjokes Quick review?

zertosh added a commit that referenced this pull request May 14, 2015
Fix globals transform noParse path matcher
@zertosh zertosh merged commit 9d1d1e3 into master May 14, 2015
@zertosh zertosh deleted the misc-fixes branch May 14, 2015 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant