Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global var insertion fixes #1361

Merged
merged 2 commits into from Sep 24, 2015
Merged

global var insertion fixes #1361

merged 2 commits into from Sep 24, 2015

Conversation

zertosh
Copy link
Member

@zertosh zertosh commented Aug 22, 2015

  • Fix --bare and --igv
  • Exclude process and buffer when bundleExternal === false

@zertosh
Fix "--bare" and "--igv"
7487bff 
"insert-module-globals" will merge any vars passed in with the default
ones. To exclude any default var, it must be passed in with a value
of "undefined".

Fixes #1298
@zertosh
Exclude "process" and "buffer" when "bundleExternal === false"
cf32d77
@zertosh zertosh changed the title globals insertion fixes global var insertion fixes Aug 22, 2015
zertosh added a commit that referenced this pull request Sep 24, 2015
@zertosh
Merge pull request #1361 from substack/fix-bare
bb2a99d 
global var insertion fixes
@zertosh zertosh merged commit bb2a99d into master Sep 24, 2015
@zertosh zertosh deleted the fix-bare branch September 24, 2015 03:51
@zertosh zertosh mentioned this pull request Oct 25, 2015
Closed
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@zertosh