Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix badly formed module paths on Windows #1424

Merged
1 commit merged into from Jan 8, 2016

Conversation

julian-maughan
Copy link
Contributor

This addresses the issue raised in #1358.

It ensures 'required' modules have the expected path, i.e. require("/apps/Call") instead of require("/apps\\Call").

@anddoutoi
Copy link

Ran into a simialar issue where both browserify -r ./foo/bar.js and browserify -r ./foo/bar.js:./foo/bar.js both returned some weird mix of absolute unix path and escaped windows path: /foo\\bar.js.

Leaving out .js in the target part works though, e.g. browserify -r ./foo/bar.js:./foo/bar returns ./foo/bar

@TheSharpieOne
Copy link

lgtm

@ghost ghost merged commit 7f80305 into browserify:master Jan 8, 2016
@ghost
Copy link

ghost commented Jan 8, 2016

Thanks for the patch, merged in 12.0.2.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants