Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cli support for --transform-key to support mode's like production… #1709

Merged
1 commit merged into from Apr 4, 2017

Conversation

serapath
Copy link
Contributor

@serapath serapath commented Apr 4, 2017

…/staging/etc..

Details see: #1706 (comment)

@serapath
Copy link
Contributor Author

serapath commented Apr 4, 2017

Can this be merged anyway even though tests are failing?
This seems to be not related to my pull request at all.

Only bin/advanced.txt, readme.markdown and bin/args.js were touched.
In bin/args.js it's just one more command line option - so i don't see how this can possibly responsible for the breaking test.

@serapath
Copy link
Contributor Author

serapath commented Apr 4, 2017

Maybe it would be even better to name it --mode or short -m instead, because --transform-key is kind of long.

@serapath
Copy link
Contributor Author

@substack another 2 pull request to fix a problem with dependencies that do not specify the alternative --transform-key. They affect browserify and module-deps.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant