update https-browserify to ^1.0.0 #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: https://github.com/substack/https-browserify/commit/7295a7cf5c0928f8fd7e 24ed8aae17801726e88b Match Node.js behavior exactly - Remove unused 'scheme' property - Throw exception if non-https URL is passed in - Support string URL arguments - First argument is always required, so remove code that sets default object if params doesn't exist
|
Tests are failing due to nodejs/nodejs.org#1191, so merging. |
This was referenced Jun 1, 2021
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/substack/https-browserify/commit/7295a7cf5c0928f8fd7e24ed8aae17801726e88b
Match Node.js behavior exactly
object if params doesn't exist