Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document suggested package naming convention #112

Open
timkelty opened this issue Sep 11, 2015 · 8 comments
Open

Document suggested package naming convention #112

timkelty opened this issue Sep 11, 2015 · 8 comments
Labels

Comments

@timkelty
Copy link
Member

e.g. suitcss-components-, suitcss-utils-

@timkelty timkelty added the docs label Sep 11, 2015
@necolas
Copy link
Contributor

necolas commented Sep 11, 2015

is anyone writing open source components and utils? should they be?

@necolas
Copy link
Contributor

necolas commented Sep 11, 2015

oh i just saw #110, ok that's cool.

@timkelty
Copy link
Member Author

I have some I just need to publish.
I know https://github.com/trunkclub has a few as well.

@giuseppeg
Copy link
Member

A good first step would be to write down some guidelines and requirements for components to qualify.
The big question there is how do we keep them consistent? @necolas do you guys have global variables for margin, padding, font-size etc?

@timkelty
Copy link
Member Author

It seems a component should always stand alone, so to me, consistency between component's variables isn't that important.

I usually end up something like:

:root {
  --App-gutter-size: 20px;
}
...
:root {
  --Arrange-gutter-size: var(--App-gutter-size);
  --Grid-gutter-size: var(--App-gutter-size);
}

@oleersoy
Copy link
Contributor

One possible requirement is that suit components should be DRY by assuming the presence of the normalize.css / base.css (Base Styles) layer.

Designers may want to leave suit off the name of the component for the reason that the component works across various frameworks, and respects the structure and conventions of all of them.

I would be great if the theme styling methodology worked really well across autonomous components...maybe it does...Need to experiment more with it. How do we get autonomous components to employ variables so that consistency across them can be plugged (Color palette, font, use of gradients, drop shadows, animation timing, etc)?

@giuseppeg
Copy link
Member

@timkelty yeah 👍 we should make that clear and a requirement I guess :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants