Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic generation of classes #161

Open
timkelty opened this issue Oct 2, 2015 · 4 comments
Open

Support dynamic generation of classes #161

timkelty opened this issue Oct 2, 2015 · 4 comments

Comments

@timkelty
Copy link
Member

timkelty commented Oct 2, 2015

Maybe a broader question as it could apply to several repos, but what do people think of using postcss plugins like postcss-for to make the generation of some of these classes dynamic?

I have done this in my own projects, and think it would likely be too much of a can of worms to include here, but thought I'd start the discussion.

@simonsmith
Copy link
Member

I wouldn't be against the idea, but it does quickly move SUIT out of the 'future facing CSS' realm.

Would be nice to be able to configure this to use 12, 16, 24 etc though.

@timkelty
Copy link
Member Author

timkelty commented Oct 2, 2015

Maybe theres an alternative -

  • We could have an alternate include with the generation stuff.
  • The main css files in the repo would be built using that with the default values
  • Then you could either include the defaults as you do now, or include the "generator" directly

Something to think about at least.

@simonsmith
Copy link
Member

I see, so each package would contain the output of the postcss tools? Could work.

Might also give more weight to moving the packages into a single repo to facilitate this.

@simonsmith simonsmith transferred this issue from suitcss/utils-size Feb 13, 2019
@mlnmln
Copy link
Contributor

mlnmln commented Mar 1, 2019

I can understand the need for that, but I have reservations against this and would like SUIT CSS to stay true to the "future facing CSS' realm." I think this should stay at user level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants