Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Blacklist to RegistrationRule #146

Open
alexander-schranz opened this issue Jan 10, 2022 · 1 comment · May be fixed by #157
Open

Rename Blacklist to RegistrationRule #146

alexander-schranz opened this issue Jan 10, 2022 · 1 comment · May be fixed by #157
Milestone
2.0

Comments

@alexander-schranz
Copy link
Member

Problem description

Currently the community bundle uses the term blacklist which we should avoid.

Proposed solution

As it some time ago discussed the list can be used to block or not block things I would suggest the name RegistrationRule and so RegistrationRuleItem for the entities.
@alexander-schranz alexander-schranz added this to the 2.0 milestone Jan 10, 2022
@alexander-schranz alexander-schranz mentioned this issue Jul 5, 2022
Closed
@alexander-schranz
Copy link
Member Author

@TheCadien said he will take a look at this issue 😃

@TheCadien TheCadien linked a pull request Aug 24, 2022 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Rename Blacklist to Registration Rule TheCadien/SuluCommunityBundle
1 participant
@alexander-schranz