Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPUnit 10 Upgrade #6988

Open
alexander-schranz opened this issue Feb 4, 2023 · 5 comments · May be fixed by #7339
Open

PHPUnit 10 Upgrade #6988

alexander-schranz opened this issue Feb 4, 2023 · 5 comments · May be fixed by #7339
Assignees
@TheCadien
Labels
Easy Pick Relatively easy to solve for newcomers as well Feature New functionality not yet included in Sulu

Comments

@alexander-schranz
Copy link
Member

alexander-schranz commented Feb 4, 2023 •
edited

Problem description

We can Upgrade Sulu 2.5 to PHPUnit 10 as Sulu 2.5 already requires atleat PHP 8.1.

Proposed solution

Upgrade to PHPUnit 10 with rector:
@alexander-schranz alexander-schranz added Feature New functionality not yet included in Sulu Easy Pick Relatively easy to solve for newcomers as well labels Feb 4, 2023
@mamazu
Copy link
Contributor

mamazu commented Feb 9, 2023

In the current version of the composer.json in the 2.5 branch 8.0 is still allowed.

@alexander-schranz
Copy link
Member Author

@mamazu good catch. Then maybe target 2.6 😄

@mamazu
Copy link
Contributor

mamazu commented Feb 14, 2023 •
edited

Currently this isn't possible. The phpspec/prophecy package doesn't yet support phpunit 10, I just checked.

@alexander-schranz
Copy link
Member Author

alexander-schranz commented Feb 15, 2023 •
edited

For preparing maybe we could test out the current PHPUnit 10 branch/pull request of prophecy to give maybe prophecy already feedback if it works with PHPUnit 10 or not.

What already could be targetted are the deprecations like:

  • assertObjectHasAttribute() is deprecated and will be removed in PHPUnit 10.
  • Expecting E_WARNING and E_USER_WARNING is deprecated and will no longer be possible in PHPUnit 10.

Currently we can test PHPUnit 10 with:

    "require-dev": {
        "phpspec/prophecy": "^1.18@dev",
        "phpspec/prophecy-phpunit": "^2.1@dev",
        "phpunit/phpunit": "^10.2"
    }

@alexander-schranz
Copy link
Member Author

alexander-schranz commented Oct 20, 2023 •
edited

@TheCadien said he will tackle this :)

@mamazu mamazu linked a pull request Mar 31, 2024 that will close this issue
Open
1 task
@mamazu mamazu mentioned this issue Apr 9, 2024
Merged
This was referenced May 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheCadien TheCadien

Labels
Easy Pick Relatively easy to solve for newcomers as well Feature New functionality not yet included in Sulu
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating to phpunit 10 mamazu/sulu
3 participants
@alexander-schranz @TheCadien @mamazu