Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security Issue with hoek due to node-gyp #1

Closed
svewag opened this issue Jul 25, 2018 · 0 comments
Closed

Security Issue with hoek due to node-gyp #1

svewag opened this issue Jul 25, 2018 · 0 comments
Labels
security

Comments

@svewag
Copy link
Contributor

svewag commented Jul 25, 2018 •
edited

Just for documentation purpose.

The current reported security issue in this project with hoek v2.16.3 is caused by node-gyp.

I dug into this, and the reason why we're pulling in an old version of hoek is because node-gyp@3.7.0 depends on request@>=2.9.0 <2.82.0

see nodejs/node-gyp#1502

Once node-gyp ships a new version with a appropriate request requirement, the security vulnerability here should be gone.

/cc @balimonster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@svewag