Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide interactivity between the table and maps #25

Open
sumwatshade opened this issue Mar 22, 2020 · 1 comment
Open

Provide interactivity between the table and maps #25

sumwatshade opened this issue Mar 22, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sumwatshade
Copy link
Owner

sumwatshade commented Mar 22, 2020

We should handle the search at a global level, passing it between the table view and the maps view. This would involve

Search

  1. moving the search field to the top of index
  2. passing the result of search via React Context API to internal components.

Marker selection

  1. use context api to have active marker available globally
  2. pass active marker details to relevant pages

Potential Experiences:

  • filter map markers based on search results
  • clicking on a business takes you to their marker
  • etc.
@sumwatshade sumwatshade added enhancement New feature or request good first issue Good for newcomers labels Mar 22, 2020
@sumwatshade
Copy link
Owner Author

@sehoven As we discussed, the Table will likely be removed for a different type of component. We should consider this when making this update.

I propose that we have one top-level state variable called activeBusiness and one called currentSearch, which will hold the data for that business. We could then pass that variable to all child components via Context.

Open to other ideas or renaming of the variables

@sumwatshade sumwatshade added this to the Project Proposal milestone Apr 4, 2020
@steebe steebe moved this from To do to In progress in 4/3/2020 - 4/17/2020 Feb 1, 2022
@steebe steebe self-assigned this Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
4/3/2020 - 4/17/2020
  
In progress
Development

No branches or pull requests

3 participants