Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure with java 1.8 #477

Open
matteriben opened this issue May 1, 2024 · 4 comments
Open

Build failure with java 1.8 #477

matteriben opened this issue May 1, 2024 · 4 comments

Comments

@matteriben
Copy link
Contributor

matteriben commented May 1, 2024

Version 0.200.0 apparently introduced a build failure for the fabric8 client when building with java sdk version 1.8.

fabric8io/kubernetes-client#5965

-    <sundrio.version>0.103.1</sundrio.version>
+    <sundrio.version>0.200.0</sundrio.version>
Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)
Maven home: /home/runner/.m2/wrapper/dists/apache-maven-3.8.4-bin/52ccbt68d252mdldqsfsn03jlf/apache-maven-3.8.4
Java version: 1.8.0_402, vendor: Temurin, runtime: /usr/lib/jvm/temurin-8-jdk-amd64/jre
Default locale: en, platform encoding: UTF-8
OS name: "linux", version: "6.5.0-1018-azure", arch: "amd64", family: "unix"
Error:  COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
Error:  /home/runner/work/kubernetes-client/kubernetes-client/kubernetes-model-generator/kubernetes-model-common/src/main/java/io/fabric8/kubernetes/model/util/Dummy.java:[18,36] cannot access io.sundr.builder.annotations.Buildable
  bad class file: /home/runner/.m2/repository/io/sundr/builder-annotations/0.200.0/builder-annotations-0.200.0.jar(io/sundr/builder/annotations/Buildable.class)
    class file has wrong version 55.0, should be 52.0
    Please remove or make sure it appears in the correct subdirectory of the classpath.
@shawkins
Copy link
Collaborator

shawkins commented May 1, 2024

@matteriben that is currently expected as the 200 baseline for sundrio was moved up to java 11. We can do a couple of things:

  • change fabric8 client to require building with java 11
  • change sundrio to create java 8 compatible jars - this will work until changes like the propsed usage of java logging creep in
  • create a .1xx branch of sundrio to produce a release without the change to the java 11 baseline.

cc @iocanel @manusa

@manusa
Copy link
Collaborator

manusa commented May 1, 2024

I thought that there was nothing critical in Sundrio to be merged in our 6.x branch (currently main/master).

@shawkins
Copy link
Collaborator

shawkins commented May 1, 2024

I thought that there was nothing critical in Sundrio to be merged in our 6.x branch (currently main/master).

The only thing I'm aware of is a bug fix with unbalanced method prefixing that would be nice to pick up

@matteriben
Copy link
Contributor Author

I thought that there was nothing critical in Sundrio to be merged in our 6.x branch (currently main/master).

The only thing I'm aware of is a test case that is currently disabled.

https://github.com/fabric8io/kubernetes-client/blob/main/java-generator/core/src/test/java/io/fabric8/java/generator/CompilationTest.java#L96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants