Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simplify query for user defined schemas #2206

Merged
merged 2 commits into from Apr 25, 2024
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Apr 24, 2024

What kind of change does this PR introduce?

chore

What is the current behavior?

Extension schemas are explicitly listed, causing problems when using package managers like dbdev.

What is the new behavior?

Use a join query to select schemas not owned by extensions.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner April 24, 2024 10:51
@coveralls
Copy link

coveralls commented Apr 24, 2024

Pull Request Test Coverage Report for Build 8815546905

Details

  • 12 of 15 (80.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 58.154%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/db/lint/lint.go 0 1 0.0%
internal/db/remote/changes/changes.go 0 1 0.0%
internal/db/remote/commit/commit.go 0 1 0.0%
Totals Coverage Status
Change from base Build 8810766962: -0.04%
Covered Lines: 6497
Relevant Lines: 11172

💛 - Coveralls

@sweatybridge sweatybridge merged commit b5e0e17 into develop Apr 25, 2024
9 checks passed
@sweatybridge sweatybridge deleted the reset-remote branch April 25, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants