Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add fixed order when selecting types to drop (fixes issue #2207) #2208

Merged
merged 3 commits into from Apr 25, 2024

Conversation

hammerlscs
Copy link
Contributor

What kind of change does this PR introduce?

Adds a fixed order when selecting the types to drop for the supabase db resetcommand.

What is the current behavior?

Currently, the order is not defined and this can lead to errors when dropping types. (More details: #2207)

What is the new behavior?

The types are dropped in a fixed order. The order is the number of type dependencies ascending.

The idea is that "base" types are always dropped before e.g. "array" types which have at least 1 type dependency to its "base" type.

@coveralls
Copy link

coveralls commented Apr 24, 2024

Pull Request Test Coverage Report for Build 8828587699

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 58.196%

Totals Coverage Status
Change from base Build 8810766962: 0.0%
Covered Lines: 6511
Relevant Lines: 11188

💛 - Coveralls

@sweatybridge sweatybridge merged commit 1c01e8e into supabase:develop Apr 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants