Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stdin should be echoed to stderr by convention #2211

Merged
merged 1 commit into from Apr 25, 2024

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Apr 25, 2024

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

Also prints error only in debug mode.

Additional context

https://unix.stackexchange.com/questions/380012/why-does-bash-interactive-shell-by-default-write-its-prompt-and-echoes-its-inter

@sweatybridge sweatybridge requested a review from a team as a code owner April 25, 2024 11:49
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8831983053

Details

  • 9 of 19 (47.37%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 58.216%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/bootstrap.go 0 1 0.0%
internal/utils/console.go 9 10 90.0%
cmd/branches.go 0 4 0.0%
internal/projects/create/create.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
cmd/bootstrap.go 1 10.91%
Totals Coverage Status
Change from base Build 8828648310: 0.02%
Covered Lines: 6508
Relevant Lines: 11179

💛 - Coveralls

@sweatybridge sweatybridge merged commit bdb60ab into develop Apr 25, 2024
9 checks passed
@sweatybridge sweatybridge deleted the console-error branch April 25, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants