Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): Update GoTrue Image to avoid signup link generation bug #2212

Merged
merged 2 commits into from Apr 26, 2024

Conversation

dagingaa
Copy link
Contributor

What kind of change does this PR introduce?

GoTrue version 2.145.0 has a bug where generating a signup link will fail with "user_not_found", which was fixed in 2.146.0 (supabase/auth#1514). Since 2.145.0 is locked in the CLI, we can't get the bug fix out, and the only fix is to downgrade to an older version.

This PR updates the image to 2.149.0 which is the most recent version as of 2024-04-22 so the signup link generation works again.

What is the current behavior?

The CLI is fixed on GoTrue version 2.145.0 which has a bug related to signup link generation.

What is the new behavior?

The CLI now uses GoTrue version 2.149.0 which does not have a bug related to signup link generation.

Additional context

GoTrue version 2.145.0 has a bug where generating a signup link will fail with "user_not_found", which was fixed in 2.146.0 (supabase/auth#1514). Since 2.145.0 is locked in the CLI, we can't get the bug fix out.

This PR updates the image to 2.149.0 which is the most recent version as of 2024-04-22 so the signup link generation works again.
@dagingaa dagingaa requested a review from a team as a code owner April 26, 2024 11:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8847432572

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 58.174%

Files with Coverage Reduction New Missed Lines %
internal/storage/rm/rm.go 2 92.86%
internal/gen/keys/keys.go 5 11.76%
Totals Coverage Status
Change from base Build 8832489737: -0.03%
Covered Lines: 6494
Relevant Lines: 11163

💛 - Coveralls

@sweatybridge sweatybridge merged commit 43ae84d into supabase:develop Apr 26, 2024
12 checks passed
@sweatybridge
Copy link
Contributor

Also you can overwrite the local gotrue version with echo "v2.149.0" > supabase/.temp/gotrue-version

This works without updating CLI

@github-actions github-actions bot mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants