Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump gotrue-js/next version #485

Merged
merged 4 commits into from Aug 5, 2022
Merged

fix: bump gotrue-js/next version #485

merged 4 commits into from Aug 5, 2022

Conversation

kangmingtay
Copy link
Member

No description provided.

@kangmingtay kangmingtay changed the base branch from master to next August 4, 2022 04:07
alaister
alaister requested changes Aug 4, 2022
View reviewed changes
Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need to update the supabase-js code that uses the now removed methods?

alaister
alaister approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
Can we also remove the isBrowser()? Not sure if it's still used anywhere?

alaister
alaister requested changes Aug 5, 2022
View reviewed changes
Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh also looks like the tests need changing to getSession() as well

@kangmingtay
Copy link
Member Author

@alaister i think we can just remove them since they are using setAuth ?

alaister
alaister approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kangmingtay yep I agree – the use case is no longer relevant.

@kangmingtay kangmingtay merged commit 501b1aa into next Aug 5, 2022
@soedirgo soedirgo deleted the km/bump-next-version branch November 1, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaister alaister alaister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kangmingtay @alaister