Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: custom authorization header should not be overwritten #584

Merged
merged 2 commits into from Oct 10, 2022
Merged

fix: custom authorization header should not be overwritten #584

merged 2 commits into from Oct 10, 2022

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

  • Fixes a bug with _initSupabaseAuthClient where it overwrites the custom Authorization header passed into SupabaseClient with the default authorization header (the supabase key)
  • The auth client should be using the custom Authorizaion header instead

@kangmingtay kangmingtay self-assigned this Oct 10, 2022
thorwebdev
thorwebdev approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@thorwebdev thorwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@kangmingtay kangmingtay merged commit 2f271f8 into rc Oct 10, 2022
@kangmingtay kangmingtay deleted the km/fix-auth-headers branch October 10, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorwebdev thorwebdev thorwebdev approved these changes

@alaister alaister Awaiting requested review from alaister

Assignees

@kangmingtay kangmingtay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kangmingtay @thorwebdev