Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output ESM build, and make module tree-shakeable #202

Merged
merged 1 commit into from Dec 15, 2018
Merged

Output ESM build, and make module tree-shakeable #202

merged 1 commit into from Dec 15, 2018

Conversation

unindented
Copy link
Contributor

Fixes #196 by doing the following:

  • Builds an ESM version of the library through an "esm" env with modules: false.
  • Adds "module" and "sideEffects" entries in package.json to notify Webpack that this module is tree-shakeable.
  • Removes createAll, as it's a choke point that imports all the things, making it impossible for Webpack to three-shake anything.
  • Moves the "rewire" plugin to only get applied during tests, as it makes no sense for it to be in production builds.

@unindented
Copy link
Contributor Author

@supasate this is now rebased against master, and ready to be reviewed.

@supasate
Copy link
Owner

LGTM! Thanks for your contribution!

@supasate supasate merged commit 87ed567 into supasate:master Dec 15, 2018
@unindented
Copy link
Contributor Author

@supasate any chance of seeing this released to npm before the end of the year?

@supasate
Copy link
Owner

@unindented Just released in v6.1.0 :).

@unindented
Copy link
Contributor Author

Awesome, thank you!

pmarfany added a commit to lluistfc/connected-react-router that referenced this pull request Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants