Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significant performance impact with v6 #229

Open
quentez opened this issue Jan 9, 2019 · 2 comments
Open

Significant performance impact with v6 #229

quentez opened this issue Jan 9, 2019 · 2 comments

Comments

@quentez
Copy link

quentez commented Jan 9, 2019

We've been trying to move to version 6 a few times since it first came out, but we always end up reverting because of its performance impact. Our average JS compute time when going from one page to the next is almost double with v6 what it was with v5.

Any idea what could be the reason for this?

@cvanem
Copy link

cvanem commented Jan 11, 2019

@quentez I recently updated to version 6 and have not noticed any slow down on a fairly large React application with 25+ routes. How much compute time are you talking about? I typically don't see anything larger than a few milliseconds when switching routes, unless there is a lot of processing involved elsewhere.

@nicoburns
Copy link

This will almost certainly be due to a performance regression in react-redux version 6.
See: reduxjs/react-redux#1164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants