Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing typedef's for getRouter and createMatchSelector #235

Merged
merged 1 commit into from Jan 20, 2019
Merged

Add missing typedef's for getRouter and createMatchSelector #235

merged 1 commit into from Jan 20, 2019

Conversation

jorgenader
Copy link
Contributor

  • Add @types/react-router as devDependency
  • Add typedef for root router state
  • Add typedef for getRouter
  • Add typedef for createMatchSelector
  • Add typedef for router selectors to expect correct root state

Fixes #128

@jorgenader
Add missing typedef's for getRouter and createMatchSelector
84310c5 
- Add `@types/react-router` as devDependency
- Add typedef for root router state
- Add typedef for `getRouter`
- Add typedef for `createMatchSelector`
- Add typedef for router selectors to expect correct root state
@supasate
Copy link
Owner

LGTM. Thanks for your contribution!

@supasate supasate merged commit bb7574f into supasate:master Jan 20, 2019
@supasate
Copy link
Owner

Released in v6.2.2.

@jorgenader jorgenader deleted the feature/missing-typedef branch January 22, 2019 09:03
@MitchWeiss MitchWeiss mentioned this pull request Feb 18, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Dec 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jorgenader @supasate