Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript error with release 6.3.0 #255

Closed
moimael opened this issue Feb 11, 2019 · 5 comments
Closed

Typescript error with release 6.3.0 #255

moimael opened this issue Feb 11, 2019 · 5 comments

Comments

@moimael
Copy link

moimael commented Feb 11, 2019

With TypeScript 3.3.1 I get this error when using connected-react-router 6.3.0:

ERROR in /Development/portal/node_modules/connected-react-router/index.d.ts(64,83):
TS2371: A parameter initializer is only allowed in a function or constructor implementation.
@NatalyMac
Copy link

Hi, guys) I have the same issue
"typescript": "^3.0.3",
"connected-react-router": "^6.3.0",
and error
ERROR in [at-loader] ./node_modules/connected-react-router/index.d.ts:64:83
TS2371: A parameter initializer is only allowed in a function or constructor implementation.
The error is here
--- export function onLocationChanged(location: Location, action: RouterActionType, isFirstRendering: boolean = false) ---

if i set to ignor this error everything works, but I need typescript.
How can I fix?

@belgattitude
Copy link

Same with typescrit 3.3.3.

@nikolay-borzov
Copy link

Will be fixed by #253

@flq
Copy link

flq commented Feb 11, 2019

@NatalyMac what do you mean by ignoring error?

Since I was just to take the plunge into redux 6.0 territory, what’s recommended here? Reverting to a previous version? Waiting?

@supasate
Copy link
Owner

Should be fixed in v6.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants