Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for react-router 5.0.0 #274

Closed
mikecousins opened this issue Mar 19, 2019 · 4 comments
Closed

Support for react-router 5.0.0 #274

mikecousins opened this issue Mar 19, 2019 · 4 comments

Comments

@mikecousins
Copy link

Should just need a peer dependency update I think. It's a non-breaking change in react-router supposedly.
@sugarshin
Copy link

+1

@mikecousins mikecousins mentioned this issue Mar 20, 2019
Merged
@cmfcmf
Copy link
Contributor

cmfcmf commented Apr 16, 2019 •
edited

This has been fixed by #273 and released in react-router@6.4.0.
Edit: I meant to say connected-react-router@6.4.0.

@Puspendert
Copy link

@cmfcmf you mean connected-react-router@6.4.0? Is it a typo by you?

@carloscuesta
Copy link

carloscuesta commented Apr 16, 2019 •
edited

Yup, this issue should be closed, as @cmfcmf stated, this change has landed at 6.4.0 and it's already released and published.

cc @supasate

https://github.com/supasate/connected-react-router/releases/tag/v6.4.0

@supasate supasate closed this as completed Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@supasate @mikecousins @sugarshin @cmfcmf @carloscuesta @Puspendert