Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move prop-types from peerDependencies into dependencies #281

Merged
merged 3 commits into from Apr 14, 2019

Conversation

cmfcmf
Copy link
Contributor

@cmfcmf cmfcmf commented Mar 28, 2019

A recent PR (#265) added prop-types to peerDependencies. I'm afraid that's not quite the right way to do it, because the official prop-types documentation states:

For libraries, we also recommend leaving it in dependencies:

  "dependencies": {
    "prop-types": "^15.5.7"
  },
  "peerDependencies": {
    "react": "^15.5.0"
  }

-- https://github.com/facebook/prop-types#how-to-depend-on-this-package

I use connected-react-router in a Typescript project and don't need prop-types, but because it is a peer-dependency I receive a "missing peer dependency warning" when installing this package.

This PR therefore removes prop-types from both peerDependencies and devDependencies.

package.json Outdated
@@ -29,11 +29,11 @@
},
"dependencies": {
"immutable": "^3.8.1",
"prop-types": "^15.5.7",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help upgrade it to ^15.7.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants