Move prop-types from peerDependencies into dependencies #281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent PR (#265) added
prop-types
topeerDependencies
. I'm afraid that's not quite the right way to do it, because the officialprop-types
documentation states:-- https://github.com/facebook/prop-types#how-to-depend-on-this-package
I use
connected-react-router
in a Typescript project and don't needprop-types
, but because it is apeer-dependency
I receive a "missing peer dependency warning" when installing this package.This PR therefore removes
prop-types
from bothpeerDependencies
anddevDependencies
.