Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOCATION_CHANGE fires twice on IOS below 9.3 #318

Open
dc-me opened this issue Jun 6, 2019 · 1 comment
Open

LOCATION_CHANGE fires twice on IOS below 9.3 #318

dc-me opened this issue Jun 6, 2019 · 1 comment

Comments

@dc-me
Copy link

dc-me commented Jun 6, 2019

In my project I used connected-react-router in LOCATION_CHANGE I do some data fetch and maintain page loading state, in IOS below 9.3 there is a bug the LOCATION_CHANGE fired twice cases my code to break. the first one is correct isFirstRendering:true, but there is a second one, isFirstRendering:false which in total fired twice, I think that's a history problem, investigating...
@dc-me
Copy link
Author

dc-me commented Jun 6, 2019 •
edited

remix-run/history#689 (comment)
It's a history problem, turns out there have been PRs and issues in the history repo, but the maintainer hasn't take it into account.

@Akiyamka Akiyamka mentioned this issue May 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dc-me