Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BrowserHistoryOptions does not contain base name #524

Open
gregryork opened this issue Jul 20, 2021 · 1 comment
Open

BrowserHistoryOptions does not contain base name #524

gregryork opened this issue Jul 20, 2021 · 1 comment

Comments

@gregryork
Copy link

The example given in the FAQ for configuring the router does not work as base name is not part of BrowserHistoryOptions. This used to work in older versions of connected-react-router, as I copied this line from a project from a few months ago.

export const history = createBrowserHistory({ basename: process.env.PUBLIC_URL, });

@gregryork
Copy link
Author

Looks like it's been removed in "history", so the correct code is now

export const history = createBrowserHistory();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant