-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Regex to match only container files more strictly #4867
Conversation
…ontainer Dockerfile but that are not actually dockerfiles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you! Appreciate the testing!
I haven't run an end to end test on this sha yet, I need to read up on running it locally. Do you know what the testing errors are about? I haven't dug in to them deeply but looks like it was expecting ansible tests that weren't found? |
I'll take a look. 👀 |
This may be the actual problem: https://github.com/super-linter/super-linter/actions/runs/6857323015/job/18646199332?pr=4867#step:9:17 |
I think there's an extra space before the regex. :) |
Also, I wonder if we can add some test cases for this regex... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think we got this one dialed in now.
Fixes #4846
Proposed Changes
We check for files with the name (case insensitive):
This appears to protect us against catching files with a name like
Dockerfile.md
I tested the regex like so:
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance