Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Using Ephemeral Machines For Health Checks #3233

Closed
benbjohnson opened this issue Feb 6, 2024 · 2 comments · Fixed by #3430
Closed

Allow Using Ephemeral Machines For Health Checks #3233

benbjohnson opened this issue Feb 6, 2024 · 2 comments · Fixed by #3430

Comments

@benbjohnson
Copy link
Contributor

benbjohnson commented Feb 6, 2024 •
edited

We could allow trust checks by running a custom ephemeral machine, where if the machine returns 0 the trust check passes, and otherwise it failed.

This would be useful for doing more complex health checks, like making sure signup functionality continues to work after a deployment.
@benbjohnson
Copy link
Contributor Author

@billyb2 Can you expand on what the workflow for this would look like? Is it something we could use fly m run for instead?

@billyb2
Copy link
Member

billyb2 commented Feb 7, 2024

I just mean that basically, flyctl after deploying the machine but before marking it as available (or uncordoning or whatever), spawns a new machine with fly m run --autodestroy. If that machine exits and returns 0, then the machine passed the health check. Otherwise, it didn't. This is especially useful for things like bluegreen deploys.

@billyb2 billyb2 changed the title Allow Using Ephemeral Machines For Trust Checks Allow Using Ephemeral Machines For Health Checks Feb 14, 2024
@billyb2 billyb2 mentioned this issue Apr 19, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Machine Based health Checks superfly/flyctl
2 participants
@benbjohnson @billyb2