-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SuperTextField] [iOS] Overriding imeController.performAction() does not behave as expected #2004
Comments
I've tried this on my end. For both super text field and super editor, I'm seeing the suggested "tom" -> "Tom" applied in both cases. Unfortunately, Miguel's machine is currently hitting an error when running Super Editor. We don't know why. @angelosilvestre can you please try these repro steps for both super text field and super editor and report back whether "tom" becomes "Tom" in both cases, or just in super text field? |
I noticed a different behavior on my end when I started using an iOS simulator on 17.5 instead of 17.0. I think Miguel said he was on 17.4. So it looks like some combination of iOS versions and Flutter may have broken us. I have the following problems on 17.5... Super Editor error when typing "run tom" and pressing "return":
Super Text Field problem in the demo app - we lose all content when pressing "done". Screen.Recording.2024-05-16.at.12.51.44.PM.movI'm gonna try to figure out the exact iOS simulator versions where this happens. Then @angelosilvestre I'll probably file two separate tickets and assign them to you. These should be done ASAP. |
I've tested 17.5, 17.4, 17.2, and both of these issues are present on all those versions. It looks like XCode doesn't even consider 17.0 to be supported any more, so we can probably consider these bugs to be present in all versions of iOS. I'll file new tickets for each issue. |
@matthew-carroll In SuperTextField with iOS 17.5 I'm seeing the same behavior that Miguel reported and the same exception you reported for SuperEditor. |
I filed the two issues for @angelosilvestre - @miguelcmedeiros I think we should hold off on this one until Angelo is at least able to fix the super editor problem. At that point we can compare SuperEditor behavior to SuperTextField behavior. |
Package Version
Using
main
on e20eb1b.To Reproduce
Steps to reproduce the behavior:
Minimal Reproduction Code
Minimal, Runnable Code Sample
Actual behavior
With the text mentioned in the reproduction steps ("Run tom"), a suggestion ("Tom") is applied.
Expected behavior
Nothing should happen since
_TextController.performAction()
does not callsuper.performAction(action)
.Platform
Only on iOS
Flutter version
Master channel with commit
d5bcd587aa72570faf12875bdfb326ab51eba961
.Screenshots
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-16.at.17.52.22.mp4
Additional context
With
SuperEditor
we can extendDeltaTextInputClientDecorator
to override the behaviour ofperformAction()
and there we don't have the problem where the IME suggestion is applied whensuper.performAction()
is not called, as expected.The text was updated successfully, but these errors were encountered: