Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Package/No JS files (neverthrow v6.2.0) #532

Closed
ninoseki opened this issue Apr 22, 2024 · 3 comments
Closed

Empty Package/No JS files (neverthrow v6.2.0) #532

ninoseki opened this issue Apr 22, 2024 · 3 comments

Comments

@ninoseki
Copy link
Contributor

Hello, first of all, thanks for creating a very useful library.

I realized that there is an issue with the latest version v6.2.0. It does not contain JS files.

$ wget https://registry.npmjs.org/neverthrow/-/neverthrow-6.2.0.tgz 
$ tar xf neverthrow-6.2.0.tgz 
$ tree package/                                                                                                                                                                  
package/
├── LICENSE
├── README.md
└── package.json

1 directory, 3 files

I guess there is something wrong with the build script or CI.

@ninoseki
Copy link
Contributor Author

It's strange because I can confirm dist files via npm pack. Maybe there was something wrong before npm publish?

$ git clone https://github.com/supermacro/neverthrow.git
$ cd neverthrow
$ npm pack
$ tar xf neverthrow-6.2.0.tgz                                                                                                                                               
$ tree package/                                                                                                                                                              
package/
├── LICENSE
├── README.md
├── dist
│   ├── index.cjs.js
│   ├── index.d.ts
│   └── index.es.js
└── package.json

2 directories, 6 files

@ninoseki
Copy link
Contributor Author

My previous comment is wrong. npm pack doesn't build/include dist directory. Now I think npm publish is done without npm run build.
#533 can prevent a similar issue.

@supermacro
Copy link
Owner

https://github.com/supermacro/neverthrow/releases/tag/v6.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants