⬆️(orbit-controls): update to work with latest aframe 1.4.1 #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyun
force-pushed
the
feat/orbit_camera_to_aframe-1.4.1
branch
from
cca1a0e
to
5f8db2f
Compare
divyun
commented
Mar 23, 2023
| </head> | ||
| <body> | ||
| <a-scene> | ||
| <a-entity supercraft-loader="name: icky-snake"></a-entity> | ||
| <a-torus-knot color="#B84A39" arc="180" p="2" q="7" radius="5" radius-tubular="0.1"></a-torus-knot> |
There was a problem hiding this comment.
Replaced the supercraft loader with a torus-knot. Supercraft loader no longer seems to work since aframe 1.1.0
|
It's unfortunate that this PR wasn't merged since 3 weeks. |
|
Ahhh! Should have checked for open PRs!!! |
Merged
|
Thanks and sorry for the delay. There are so many PRs to juggle and components to maintain :) Thanks everyone for the effort. Glad that orbit controls is now in good shape |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #311