Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[template] case mustache return handlebars compiler #329

Open
isaac-pj opened this issue May 17, 2023 · 1 comment
Open

[template] case mustache return handlebars compiler #329

isaac-pj opened this issue May 17, 2023 · 1 comment

Comments

@isaac-pj
Copy link

The package aframe-template-component in npm version 3.2.1

When i try to render mustache template an error is throwed out on console.

mustache.min.js:1 Uncaught (in promise) TypeError: Invalid template! Template should be a "string" but "function" was given as the first argument for mustache#render(template, view, partials)
    at Object.render (mustache.min.js:1:9011)
    at renderTemplate (index.js:109:23)
    at n.renderTemplate (index.js:78:28)

checking the index.js at line :184 i see that the case is wrongly returning handlebars compiler for mustache case

    case MUSTACHE: {
      return compileHandlebarsTemplate;
    }

I see that the problem was fixed on this commit 4d1a49b 6 years before, but the package was published in last 3 months and the bug there is.

@vincentfretin
Copy link
Contributor

3.2.2 was published https://www.npmjs.com/package/aframe-template-component I guess you can close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants