Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility #104

Open
2 of 17 tasks
sapegin opened this issue Jun 23, 2018 · 2 comments
Open
2 of 17 tasks

Improve accessibility #104

sapegin opened this issue Jun 23, 2018 · 2 comments

Comments

@sapegin
Copy link
Member

sapegin commented Jun 23, 2018

I've done a quick a11y audit, and here are some things we can improve. Most of the changes are trivial.

  • Add eslint-plugin-jsx-a11y
  • Add focused style for links (disabled with outline:0)
  • Enable page zooming on mobile devices
    <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1, minimal-ui">
  • Improve colors contrast ratio (required 4.5:1)
    • Links (current ratio is 2.29:1)
    • Check other colors too
  • Hide heading links from screen readers
    Right now we have two tags without any content. I guess we can use only one link.
    Screenshot
  • Ensures all content is contained within a landmark region
    • Wrap main content in a main landmark element (<main role="main">)
    • Wrap heading and footer in and tags
  • Use one level of headings on the homepage for “Learn JavaScript. SurviveJS will…”
    Screenshot
  • Make search more accessible. It has some aria-attributes but there’s no way to know that it’s a search field
  • Make sure that all input fields have accessible labels
  • Add accessible titles books in the footer (right now we only have an image with an alt like “Book name cover”)
  • Make sure that the hamburger menu is accessible
  • Subscription form: add focus style to the submit button
  • Add "skip navigation" link
@bebraw
Copy link
Member

bebraw commented Jun 25, 2018

Looks good. Maybe you can do a couple of passes (separate PRs) on this as you prefer. 👍

@sapegin
Copy link
Member Author

sapegin commented Jun 25, 2018

Yeah, there would be too much to do at once ;-)

sapegin pushed a commit that referenced this issue Oct 17, 2018
sapegin pushed a commit that referenced this issue Oct 17, 2018
bebraw pushed a commit that referenced this issue Oct 17, 2018
bebraw pushed a commit that referenced this issue Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants