Skip to content

Multiple merging has TypeScript error #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tysonmatanich opened this issue Jan 28, 2019 · 8 comments · Fixed by #135
Closed

Multiple merging has TypeScript error #112

tysonmatanich opened this issue Jan 28, 2019 · 8 comments · Fixed by #135
Milestone

Comments

@tysonmatanich
Copy link

The example (https://github.com/survivejs/webpack-merge#multiple-merging) for multiple merging gives the following TypeScript error:

Type '{ server: { target: string; output: { path: string; filename: string; }; }; client: { output: { path: string; filename: string; }; }; }' has no properties in common with type 'Configuration'.

The Configuration interface imported from webpack (@types/webpack) doesn't allow for server/client object keys. Something like the following could allow for this:

interface ConfigurationMap {
  [name: string]: Configuration;
}
@logusgraphics
Copy link

Same as #110

@uinz
Copy link

uinz commented Apr 15, 2019

I create a PR

@chinesedfan
Copy link
Contributor

@uinz's PR has been merged, so it should be fixed, as well as #110.

@rpivo
Copy link

rpivo commented Feb 16, 2020

Does anyone have any more info on this other than #110 and #112? I've been troubleshooting typing issues using webpack-dev-server with webpack-merge.

@trulysinclair
Copy link

merge({...},frontend as webpack.Configuration) works just fine, except I can't use conditional plugins or it fails.

@bebraw bebraw added this to the v5 milestone Jun 29, 2020
@bebraw
Copy link
Member

bebraw commented Jun 29, 2020

This will get fixed in v5 (ported to TS).

@chinesedfan
Copy link
Contributor

@bebraw Hi, what's the progress of v5 and how can I help?

@bebraw
Copy link
Member

bebraw commented Jun 30, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants