We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Learn more about funding links in repositories.
Report abuse
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi, this function is wrong:
webpack-merge/src/join-arrays.ts
Lines 63 to 65 in 2e8780e
true
a
null
isPlainObject(null) === true
The text was updated successfully, but these errors were encountered:
I went with the minimal amount of external dependencies.
Can you send me a test case where the current check is problematic? Simple configurations to merge would do.
Sorry, something went wrong.
const { merge } = require("webpack-merge") const a = { devServer: { base: true } } const b = { devServer: null } console.log(merge(a, b))
expected result: { devServer: null }
{ devServer: null }
4eb811c
Fixed in 5.1.2. Thanks!
5.1.2
No branches or pull requests
Hi, this function is wrong:
webpack-merge/src/join-arrays.ts
Lines 63 to 65 in 2e8780e
because returns
true
whena
isnull
so currently,isPlainObject(null) === true
. Why not use is-plain-object package instead?The text was updated successfully, but these errors were encountered: