Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: remove ConvertByte and change signature of Convert #45

Merged
merged 1 commit into from Feb 21, 2021

Conversation

suzuki-shunsuke
Copy link
Owner

@suzuki-shunsuke suzuki-shunsuke commented Feb 21, 2021

BREAKING CHANGE: remove ConvertByte and change signature of Convert

AS IS

Convert(x interface{}) (interface{}, error)

TO BE

Convert(x, dst interface{}) error

@suzuki-shunsuke suzuki-shunsuke added this to the v2.0.0 milestone Feb 21, 2021
BREAKING CHANGE: remove ConvertByte and change signature of Convert
@suzuki-shunsuke suzuki-shunsuke changed the title feat: change API of Convert and ConvertByte BREAKING CHANGE: remove ConvertByte and change signature of Convert Feb 21, 2021
@suzuki-shunsuke suzuki-shunsuke merged commit 39d753a into master Feb 21, 2021
@suzuki-shunsuke suzuki-shunsuke deleted the perf/change-api-interface branch February 21, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant