Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBUILD_MW_REG_TESTS requires h5m models that can't be found as URL missing #858

Open
shimwell opened this issue Feb 17, 2023 · 9 comments
Open
Assignees

Comments

@shimwell
Copy link
Member

shimwell commented Feb 17, 2023

Describe the Bug

The CI has a variable called DBUILD_MW_REG_TESTS which is if set will trigger the downloading of a tar.gz file containing some h5m geometries from a URL. Unfortunately it looks like the URL used by the wget command has been lost in in the CI transition from travis-ci to circle-ci. I understand that these models are large and the tests are lengthy hence it was an optional test. It looks like we have accidentally gone on for a while without noticing that these tests were not running any more and this was recently noticed during #822

To Reproduce

compile dagmc with the DBUILD_MW_REG_TESTS variable

mkdir build
cd build
cmake .. DBUILD_MW_REG_TESTS=ON
make -j
make install
make test

Expected Behavior

tests should pass

Please complete the following information regarding your system:

all OS and MOAB versions

Additional Context

Link to PR where this issue was found and is also discussed

@gonuke
Copy link
Member

gonuke commented Feb 17, 2023

I tagged @pshriwise only because he may actually know where the necessary H5M files are for testing....

@shimwell
Copy link
Member Author

shimwell commented Mar 2, 2023

Filenames of the missing files

class ITERMakeWatertightRegressionTest : public MakeWatertightTest {
 protected:
  virtual void setFilename() { filename = "iter_imprinted.h5m"; };
};

class FNSFMakeWatertightRegressionTest : public MakeWatertightTest {
 protected:
  virtual void setFilename() { filename = "model1_360_1.h5m"; };
};

class BLiteMakeWatertightRegressionTest : public MakeWatertightTest {
 protected:
  virtual void setFilename() { filename = "bllite30matls.h5m"; };
};

@ahnaf-tahmid-chowdhury
Copy link
Member

Is the issue already fixed?

@shimwell
Copy link
Member Author

shimwell commented Feb 14, 2024

I think this one was never solved. But perhaps not a high priority

@gonuke
Copy link
Member

gonuke commented Feb 15, 2024

I think we lost the files, right @pshriwise ?

@ahnaf-tahmid-chowdhury
Copy link
Member

Is it possible to recreate the files if they are lost? I am willing to work on that. I need instructions on how to create h5m geometries for this.

@gonuke
Copy link
Member

gonuke commented Feb 15, 2024

These were a set of specific H5M files that were useful for these tests. It is not as simple as just creating some new H5M files.

@ahnaf-tahmid-chowdhury
Copy link
Member

Always happy to learn new stuffs. If the creator tells me the process how to make those H5M files for these tests, I will definitely give that a try.

@shimwell
Copy link
Member Author

I think the shape, volume etc of the missing h5m files is lost now.

We can close this one as I think it is impossible to recover these h5m files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants