Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CI tools like changesets for changelog and releasing #166

Closed
JounQin opened this issue Jul 1, 2022 · 7 comments · Fixed by #220
Closed

Use CI tools like changesets for changelog and releasing #166

JounQin opened this issue Jul 1, 2022 · 7 comments · Fixed by #220
Assignees
Labels
internal This affects the hidden internals

Comments

@JounQin
Copy link
Collaborator

JounQin commented Jul 1, 2022

@JounQin
Copy link
Collaborator Author

JounQin commented Jul 1, 2022

And also these projects seem lack of git hooks tools like simple-git-hooks + lint-staged?

How do you think of them?

@ota-meshi
Copy link
Member

I agree to introduce those tools 👍

@JounQin JounQin self-assigned this Aug 9, 2022
@JounQin JounQin added the internal This affects the hidden internals label Aug 9, 2022
@JounQin
Copy link
Collaborator Author

JounQin commented Aug 10, 2022

@ota-meshi

I'd like to work on this recently.

A few questions to discuss:

  1. Do you want to release npm package manually or by CI automatically instead?
  2. Do you have unified configs to be reused for tools like simple-git-hooks and lint-staged? Yours is always preferred here. If not can I use mine at https://github.com/1stG/configs/tree/master/packages Or they should just be used verbose.
  3. Do we use https://github.com/conventional-changelog/commitlint/tree/master/@commitlint/config-conventional?
  4. Do we use https://github.com/remarkjs/remark-lint which can be integrated with ESLint via eslint-mdx?
  5. Do we enable codesanbox ci for easy testing for users before publishing? See ci: integration with changesets import-js/eslint-import-resolver-typescript#118 (comment)
  6. Do we use lgtm.com? I found it very useful at https://lgtm.com/projects/g/un-ts/domiso/snapshot/b5742fb00f85aafe572c4aa0291e2c65391cc830/files/src/index.ts?sort=name&dir=ASC&mode=heatmap#L12

@ota-meshi
Copy link
Member

ota-meshi commented Aug 11, 2022

Do you want to release npm package manually or by CI automatically instead?

I prefer automatically release, but manually release is okay.

I don't know much about other tools as I haven't used them much. I think that it can be adjusted later if there is a problem after introducing it once.

@JounQin
Copy link
Collaborator Author

JounQin commented Aug 12, 2022

OK, I'll install some GitHub Apps on this repo, it may require you to accept the installation.

@JounQin
Copy link
Collaborator Author

JounQin commented Aug 12, 2022

@ota-meshi

I found I can not install any GitHub Apps due to lack of permission on a personal repository. 🤣

A GitHub organization is much more suitable for such cases.

Can you help to install them manually?

https://github.com/apps/changeset-bot/installations/new
https://github.com/apps/codesandbox-ci/installations/new
https://github.com/apps/lgtm-com/installations/new

Secondly, actions secrets like NPM_TOKEN need to be provided.

@ota-meshi
Copy link
Member

I have installed 3 apps into this project and svelte-eslint-parser repo.
Secrets has also been set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal This affects the hidden internals
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants