From 11b4ec7698b48cb3598d2190f34e26d62ebb9198 Mon Sep 17 00:00:00 2001 From: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Sun, 11 Dec 2022 19:51:18 +0100 Subject: [PATCH] (fix) data-sveltekit attributes are valid on all elements (#1773) #1772 --- packages/svelte2tsx/svelte-html-do-not-use.d.ts | 12 ++++++------ packages/svelte2tsx/svelte-jsx.d.ts | 16 +++++++--------- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/packages/svelte2tsx/svelte-html-do-not-use.d.ts b/packages/svelte2tsx/svelte-html-do-not-use.d.ts index 7c9f6cb89..f2fc97ac0 100644 --- a/packages/svelte2tsx/svelte-html-do-not-use.d.ts +++ b/packages/svelte2tsx/svelte-html-do-not-use.d.ts @@ -538,6 +538,12 @@ export interface HTMLAttributes extends AriaAttributes, D * Elements with the contenteditable attribute support innerHTML and textContent bindings. */ 'bind:textContent'?: string | undefined | null; + + // SvelteKit + 'data-sveltekit-noscroll'?: true | '' | 'off' | undefined | null; + 'data-sveltekit-preload-code'?: true | '' | 'eager' | 'viewport' | 'hover' | 'tap' | 'off' | undefined | null; + 'data-sveltekit-preload-data'?: true | '' | 'hover' | 'tap' | 'off' | undefined | null; + 'data-sveltekit-reload'?: true | '' | 'off' | undefined | null; } export type HTMLAttributeAnchorTarget = @@ -558,12 +564,6 @@ export interface HTMLAnchorAttributes extends HTMLAttributes type?: string | undefined | null; referrerpolicy?: ReferrerPolicy | undefined | null; - // SvelteKit - 'data-sveltekit-noscroll'?: true | '' | 'off' | undefined | null; - 'data-sveltekit-preload-code'?: true | '' | 'eager' | 'viewport' | 'hover' | 'tap' | 'off' | undefined | null; - 'data-sveltekit-preload-data'?: true | '' | 'hover' | 'tap' | 'off' | undefined | null; - 'data-sveltekit-reload'?: true | '' | 'off' | undefined | null; - // Sapper 'sapper:noscroll'?: true | undefined | null; 'sapper:prefetch'?: true | undefined | null; diff --git a/packages/svelte2tsx/svelte-jsx.d.ts b/packages/svelte2tsx/svelte-jsx.d.ts index fe6c391b8..261067e33 100644 --- a/packages/svelte2tsx/svelte-jsx.d.ts +++ b/packages/svelte2tsx/svelte-jsx.d.ts @@ -839,6 +839,11 @@ declare namespace svelte.JSX { results?: number | undefined | null; security?: string | undefined | null; unselectable?: boolean | undefined | null; + + 'data-sveltekit-noscroll'?: true | '' | 'off' | undefined | null; + 'data-sveltekit-preload-code'?: true | '' | 'eager' | 'viewport' | 'hover' | 'tap' | 'off' | undefined | null; + 'data-sveltekit-preload-data'?: true | '' | 'hover' | 'tap' | 'off' | undefined | null; + 'data-sveltekit-reload'?: true | '' | 'off' | undefined | null; } // this list is "complete" in that it contains every SVG attribute @@ -1176,13 +1181,6 @@ declare namespace svelte.JSX { sapperPrefetch?: true | undefined | null; } - interface SvelteKitAnchorProps { - 'data-sveltekit-noscroll'?: true | '' | 'off' | undefined | null; - 'data-sveltekit-preload-code'?: true | '' | 'eager' | 'viewport' | 'hover' | 'tap' | 'off' | undefined | null; - 'data-sveltekit-preload-data'?: true | '' | 'hover' | 'tap' | 'off' | undefined | null; - 'data-sveltekit-reload'?: true | '' | 'off' | undefined | null; - } - interface SvelteMediaTimeRange { start: number; end: number; @@ -1221,7 +1219,7 @@ declare namespace svelte.JSX { interface IntrinsicElements { // HTML - a: HTMLProps & SapperAnchorProps & SvelteKitAnchorProps; + a: HTMLProps & SapperAnchorProps; abbr: HTMLProps; address: HTMLProps; area: HTMLProps; @@ -1398,7 +1396,7 @@ declare namespace svelte.JSX { sveltefragment: { slot?: string; }; svelteoptions: { [name: string]: any }; sveltehead: { [name: string]: any }; - svelteelement: { 'this': string | undefined | null; } & HTMLProps & SVGProps & SapperAnchorProps & SvelteKitAnchorProps; + svelteelement: { 'this': string | undefined | null; } & HTMLProps & SVGProps & SapperAnchorProps; // Needed due to backwards compatibility type which hits these 'svelte:window': HTMLProps & SvelteWindowProps; 'svelte:body': HTMLProps;