docs/preprocessors/typescript.md

@@ -73,7 +73,7 @@ export interface FooSlots {
 export default class Foo extends SvelteComponentTyped<FooProps, FooEvents, FooSlots> {}
 ```
 
-SvelteKit's `package` command will give you these capabilities - transpiling and creating type definitions - out of the box: https://kit.svelte.dev/docs#packaging
+SvelteKit's `package` command will give you these capabilities - transpiling and creating type definitions - out of the box: https://kit.svelte.dev/docs/packaging
 
 ## Typing component events
 

packages/language-server/package.json

@@ -54,7 +54,7 @@
         "lodash": "^4.17.21",
         "prettier": "2.5.1",
         "prettier-plugin-svelte": "~2.7.0",
-        "svelte": "^3.48.0",
+        "svelte": "^3.49.0",
         "svelte-preprocess": "~4.10.1",
         "svelte2tsx": "~0.5.0",
         "typescript": "*",

packages/language-server/src/lib/documents/Document.ts

@@ -113,6 +113,17 @@ export class Document extends WritableDocument {
         return lang.replace(/^text\//, '');
     }
 
+    /**
+     * Returns true if there's `lang="X"` on script or style or template.
+     */
+    hasLanguageAttribute(): boolean {
+        return (
+            !!this.getLanguageAttribute('script') ||
+            !!this.getLanguageAttribute('style') ||
+            !!this.getLanguageAttribute('template')
+        );
+    }
+
     private addDefaultLanguage(
         config: SvelteConfig | undefined,
         tagInfo: TagInformation | null,

packages/language-server/src/lib/documents/configLoader.ts

@@ -22,6 +22,8 @@ export interface SvelteConfig {
     compilerOptions?: CompileOptions;
     preprocess?: InternalPreprocessorGroup | InternalPreprocessorGroup[];
     loadConfigError?: any;
+    isFallbackConfig?: boolean;
+    kit?: any;
 }
 
 const DEFAULT_OPTIONS: CompileOptions = {
@@ -257,7 +259,8 @@ export class ConfigLoader {
                     transpileOnly: true,
                     compilerOptions: { sourceMap: true, inlineSourceMap: false }
                 }
-            })
+            }),
+            isFallbackConfig: true
         };
     }
 }

packages/language-server/src/plugins/svelte/features/getDiagnostics.ts

@@ -91,6 +91,16 @@ async function createParserErrorDiagnostic(error: any, document: Document) {
             document.scriptInfo || document.moduleScriptInfo
         );
 
+        if (
+            (!document.config?.preprocess || document.config.isFallbackConfig) &&
+            document.hasLanguageAttribute()
+        ) {
+            Logger.error(
+                `Parsing ${document.getFilePath()} failed. No preprocess config found but lang tag exists. Skip showing error because they likely use other preprocessors.`
+            );
+            return [];
+        }
+
         if (isInStyle || isInScript) {
             diagnostic.message +=
                 '\n\nIf you expect this syntax to work, here are some suggestions: ';

packages/language-server/src/plugins/typescript/ComponentInfoProvider.ts

@@ -8,7 +8,8 @@ export type ComponentPartInfo = ReturnType<ComponentEvents['getAll']>;
 export interface ComponentInfoProvider {
     getEvents(): ComponentPartInfo;
     getSlotLets(slot?: string): ComponentPartInfo;
-    getProps(propName: string): ts.CompletionEntry[];
+    getProps(): ComponentPartInfo;
+    getProp(propName: string): ts.CompletionEntry[];
 }
 
 export class JsOrTsComponentInfoProvider implements ComponentInfoProvider {
@@ -45,7 +46,16 @@ export class JsOrTsComponentInfoProvider implements ComponentInfoProvider {
         return this.mapPropertiesOfType(slotLetsType);
     }
 
-    getProps(propName: string): ts.CompletionEntry[] {
+    getProps() {
+        const props = this.getType('$$prop_def');
+        if (!props) {
+            return [];
+        }
+
+        return this.mapPropertiesOfType(props);
+    }
+
+    getProp(propName: string): ts.CompletionEntry[] {
         const props = this.getType('$$prop_def');
         if (!props) {
             return [];

packages/language-server/src/plugins/typescript/DocumentSnapshot.ts

@@ -96,12 +96,13 @@ export namespace DocumentSnapshot {
     export function fromFilePath(
         filePath: string,
         createDocument: (filePath: string, text: string) => Document,
-        options: SvelteSnapshotOptions
+        options: SvelteSnapshotOptions,
+        tsSystem: ts.System
     ) {
         if (isSvelteFilePath(filePath)) {
             return DocumentSnapshot.fromSvelteFilePath(filePath, createDocument, options);
         } else {
-            return DocumentSnapshot.fromNonSvelteFilePath(filePath);
+            return DocumentSnapshot.fromNonSvelteFilePath(filePath, tsSystem);
         }
     }
 
@@ -110,7 +111,7 @@ export namespace DocumentSnapshot {
      * @param filePath path to the js/ts file
      * @param options options that apply in case it's a svelte file
      */
-    export function fromNonSvelteFilePath(filePath: string) {
+    export function fromNonSvelteFilePath(filePath: string, tsSystem: ts.System) {
         let originalText = '';
 
         // The following (very hacky) code makes sure that the ambient module definitions
@@ -121,7 +122,7 @@ export namespace DocumentSnapshot {
         // on their own.
         const normalizedPath = filePath.replace(/\\/g, '/');
         if (!normalizedPath.endsWith('node_modules/svelte/types/runtime/ambient.d.ts')) {
-            originalText = ts.sys.readFile(filePath) || '';
+            originalText = tsSystem.readFile(filePath) || '';
         }
         if (
             normalizedPath.endsWith('svelte2tsx/svelte-shims.d.ts') ||

packages/language-server/src/plugins/typescript/LSAndTSDocResolver.ts

@@ -1,3 +1,4 @@
+import { dirname } from 'path';
 import ts from 'typescript';
 import { TextDocumentContentChangeEvent } from 'vscode-languageserver';
 import { Document, DocumentManager } from '../../lib/documents';
@@ -27,6 +28,7 @@ interface LSAndTSDocResolverOptions {
 
     onProjectReloaded?: () => void;
     watchTsConfig?: boolean;
+    tsSystem?: ts.System;
 }
 
 export class LSAndTSDocResolver {
@@ -69,7 +71,7 @@ export class LSAndTSDocResolver {
         return document;
     };
 
-    private globalSnapshotsManager = new GlobalSnapshotsManager();
+    private globalSnapshotsManager = new GlobalSnapshotsManager(this.lsDocumentContext.tsSystem);
     private extendedConfigCache = new Map<string, ts.ExtendedConfigCacheEntry>();
 
     private get lsDocumentContext(): LanguageServiceDocumentContext {
@@ -83,7 +85,7 @@ export class LSAndTSDocResolver {
             extendedConfigCache: this.extendedConfigCache,
             onProjectReloaded: this.options?.onProjectReloaded,
             watchTsConfig: !!this.options?.watchTsConfig,
-            tsSystem: ts.sys
+            tsSystem: this.options?.tsSystem ?? ts.sys
         };
     }
 
@@ -168,7 +170,11 @@ export class LSAndTSDocResolver {
 
     async getTSService(filePath?: string): Promise<LanguageServiceContainer> {
         if (this.options?.tsconfigPath) {
-            return getServiceForTsconfig(this.options?.tsconfigPath, this.lsDocumentContext);
+            return getServiceForTsconfig(
+                this.options?.tsconfigPath,
+                dirname(this.options.tsconfigPath),
+                this.lsDocumentContext
+            );
         }
         if (!filePath) {
             throw new Error('Cannot call getTSService without filePath and without tsconfigPath');

packages/language-server/src/plugins/typescript/SnapshotManager.ts

@@ -16,6 +16,8 @@ export class GlobalSnapshotsManager {
     private emitter = new EventEmitter();
     private documents = new Map<string, DocumentSnapshot>();
 
+    constructor(private readonly tsSystem: ts.System) {}
+
     get(fileName: string) {
         fileName = normalizePath(fileName);
         return this.documents.get(fileName);
@@ -48,7 +50,7 @@ export class GlobalSnapshotsManager {
             this.emitter.emit('change', fileName, previousSnapshot);
             return previousSnapshot;
         } else {
-            const newSnapshot = DocumentSnapshot.fromNonSvelteFilePath(fileName);
+            const newSnapshot = DocumentSnapshot.fromNonSvelteFilePath(fileName, this.tsSystem);
 
             if (previousSnapshot) {
                 newSnapshot.version = previousSnapshot.version + 1;

packages/language-server/src/plugins/typescript/TypeScriptPlugin.ts

@@ -455,7 +455,18 @@ export class TypeScriptPlugin
         for (const { fileName, changeType } of onWatchFileChangesParas) {
             const pathParts = fileName.split(/\/|\\/);
             const dirPathParts = pathParts.slice(0, pathParts.length - 1);
-            if (ignoredBuildDirectories.some((dir) => dirPathParts.includes(dir))) {
+            const declarationExtensions = [ts.Extension.Dcts, ts.Extension.Dts, ts.Extension.Dmts];
+            const canSafelyIgnore =
+                declarationExtensions.every((ext) => !fileName.endsWith(ext)) &&
+                ignoredBuildDirectories.some((dir) => {
+                    const index = dirPathParts.indexOf(dir);
+
+                    return (
+                        // Files in .svelte-kit/types should always come through
+                        index > 0 && (dir !== '.svelte-kit' || dirPathParts[index + 1] !== 'types')
+                    );
+                });
+            if (canSafelyIgnore) {
                 continue;
             }
 

packages/language-server/src/plugins/typescript/features/CodeActionsProvider.ts

@@ -4,6 +4,7 @@ import {
     CodeAction,
     CodeActionContext,
     CodeActionKind,
+    Diagnostic,
     OptionalVersionedTextDocumentIdentifier,
     Range,
     TextDocumentEdit,
@@ -257,8 +258,19 @@ export class CodeActionsProviderImpl implements CodeActionsProvider {
         const start = tsDoc.offsetAt(tsDoc.getGeneratedPosition(range.start));
         const end = tsDoc.offsetAt(tsDoc.getGeneratedPosition(range.end));
         const errorCodes: number[] = context.diagnostics.map((diag) => Number(diag.code));
-        let codeFixes = errorCodes.includes(2304) // "Cannot find name '...'."
-            ? this.getComponentImportQuickFix(start, end, lang, tsDoc.filePath, userPreferences)
+        const cannotFoundNameDiagnostic = context.diagnostics.filter(
+            (diagnostic) => diagnostic.code === 2304
+        ); // "Cannot find name '...'."
+
+        let codeFixes = cannotFoundNameDiagnostic.length
+            ? this.getComponentImportQuickFix(
+                  start,
+                  end,
+                  lang,
+                  tsDoc,
+                  userPreferences,
+                  cannotFoundNameDiagnostic
+              )
             : undefined;
         codeFixes =
             // either-or situation
@@ -373,10 +385,11 @@ export class CodeActionsProviderImpl implements CodeActionsProvider {
         start: number,
         end: number,
         lang: ts.LanguageService,
-        filePath: string,
-        userPreferences: ts.UserPreferences
+        tsDoc: DocumentSnapshot,
+        userPreferences: ts.UserPreferences,
+        diagnostics: Diagnostic[]
     ): readonly ts.CodeFixAction[] | undefined {
-        const sourceFile = lang.getProgram()?.getSourceFile(filePath);
+        const sourceFile = lang.getProgram()?.getSourceFile(tsDoc.filePath);
 
         if (!sourceFile) {
             return;
@@ -402,9 +415,23 @@ export class CodeActionsProviderImpl implements CodeActionsProvider {
         }
 
         const tagName = ts.isIdentifier(node) ? node : node.tagName;
+        const tagNameEnd = tagName.getEnd();
+        const tagNameEndOriginalPosition = tsDoc.offsetAt(
+            tsDoc.getOriginalPosition(tsDoc.positionAt(tagNameEnd))
+        );
+        const hasDiagnosticForTag = diagnostics.some(
+            ({ range }) =>
+                tsDoc.offsetAt(range.start) <= tagNameEndOriginalPosition &&
+                tagNameEndOriginalPosition <= tsDoc.offsetAt(range.end)
+        );
+
+        if (!hasDiagnosticForTag) {
+            return;
+        }
+
         const completion = lang.getCompletionsAtPosition(
-            filePath,
-            tagName.getEnd(),
+            tsDoc.filePath,
+            tagNameEnd,
             userPreferences
         );
 
@@ -420,7 +447,7 @@ export class CodeActionsProviderImpl implements CodeActionsProvider {
         const toFix = (c: ts.CompletionEntry) =>
             lang
                 .getCompletionEntryDetails(
-                    filePath,
+                    tsDoc.filePath,
                     end,
                     c.name,
                     {},