Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) extract name in destructuring with default #1605

Merged
merged 2 commits into from Aug 28, 2022

Conversation

jasonlyu123
Copy link
Member

@jasonlyu123 jasonlyu123 commented Aug 27, 2022

#1604 Missed one spot when we adopt periscopic for typescript AST.

There's still one left that's not adopted.

https://github.com/Rich-Harris/periscopic/blob/2ff43ecd3e60a660acce552046d5c6eac0586ae7/src/index.js#L230

Still not sure what that's for. Parameter like (...args) ? Not sure if our use case would use that.

@jasonlyu123 jasonlyu123 changed the title Extract with default (fix) extract name in destructuring with default Aug 27, 2022
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure either, but doesn't seem related to our use case, so let's ignore it for now

@dummdidumm dummdidumm merged commit 5f0d769 into sveltejs:master Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants