(fix) generic support for component getter and accessor

[jasonlyu123]

#1688

[dummdidumm]

Do you know why we don't transform getters by doing get foo() { return this.$$prop_def.foo }? This should work the same for components with and without generics.

[jasonlyu123]

I think it's because it wasn't a part of the props back then and we made it props later.

[dummdidumm]

Mhm, maybe (I thought $$prop_def always existed, but my memory might be tricking me 😅 ). Either way, if there's nothing speaking against it, I'd say it's probably better to transform it that way now, which would make special code for the generic case unnecessary. What do you think?

[jasonlyu123]

It was originally not in the props returned in the render. And there's a separate getter. Then we also add the getters into props. If we change to directly use $$prop_def. Do we still need to keep the getters?

[dummdidumm]

mhhm I think we can probably remove getters from the transpiled output then. We can't remove this.getters from ExportedNames though because that's used to distinguish between props that are writeable (export let ..) and those that are only readable (export const/function ..)

[dummdidumm]

Nice one! Is this ready to merge?

[jasonlyu123]

It's ready. Any other thing you want to change?