Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with updating magic-string #2286

Open
dummdidumm opened this issue Feb 7, 2024 · 0 comments
Open

Problems with updating magic-string #2286

dummdidumm opened this issue Feb 7, 2024 · 0 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@dummdidumm
Copy link
Member

dummdidumm commented Feb 7, 2024

Wanted to give updating magic-string in svelte2tsx a shot but it seems that Rich-Harris/magic-string#261 in some way broke our code generation.

The minimum reproduction is this:
Bump magic-string in svelte2tsx to the latest version, then try renaming blubb in this file and you'll see it removes the braces:

<script>
    let blubb;
</script>
{blubb}

I'm not sure yet if this is because we're doing something unsupported/unintended or if this is a bug within magic-string.

@dummdidumm dummdidumm added the dependencies Pull requests that update a dependency file label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant